Add doctest to trapezoidal_rule #11274
Conversation
algorithms-keeper
bot
added
enhancement
|
What do you mean? Are the doctests wrong or are you talking about the ruff check failing? |
|
@kyrtsouv The doctests seem to be fine since the build passes. The ruff errors are probably due to newly added ruff rules—try rebasing your code to get it up-to-date and see if that fixes things. |
| @@ -9,7 +9,7 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| def method_1(boundary, steps): | |||
| def method_1(func, boundary, steps): | |||
There was a problem hiding this comment.
This function is entirely untested
| @@ -20,29 +20,70 @@ def method_1(boundary, steps): | |||
| y += (h / 2.0) * f(a) | |||
| for i in x_i: | |||
| # print(i) | |||
| y += h * f(i) | |||
| y += h * f(func, i) | |||
There was a problem hiding this comment.
I don't see the need for the function f. Why not just run func directly?
| @@ -20,29 +20,70 @@ def method_1(boundary, steps): | |||
| y += (h / 2.0) * f(a) | |||
| for i in x_i: | |||
| # print(i) | |||
| y += h * f(i) | |||
| y += h * f(func, i) | |||
| y += (h / 2.0) * f(b) | |||
There was a problem hiding this comment.
Was this instance of f meant to be changed to func as well?
| def f(y, x): # enter your function here | ||
| """ | ||
| Returns the value of a lambda functiοn y at x | ||
| >>> f(lambda x: x**2,2) | ||
| 4 | ||
| >>> f(lambda x: x**2,-1) | ||
| 1 | ||
| >>> f(lambda x: (x+1)/2,5) | ||
| 3.0 | ||
| >>> f(lambda x: (x+1)/2,0) | ||
| 0.5 | ||
| """ | ||
| return y(x) |
There was a problem hiding this comment.
See previous comment: why have a wrapper function for a function rather than just running the function directly?
| >>> x_i = make_points(0, 0.4, 0.1) | ||
| >>> next(x_i) | ||
| 0.1 | ||
| >>> next(x_i) | ||
| 0.2 | ||
| >>> next(x_i) | ||
| 0.3 | ||
| >>> next(x_i) | ||
| Traceback (most recent call last): | ||
| ... | ||
| StopIteration |
There was a problem hiding this comment.
| >>> x_i = make_points(0, 0.4, 0.1) | |
| >>> next(x_i) | |
| 0.1 | |
| >>> next(x_i) | |
| 0.2 | |
| >>> next(x_i) | |
| 0.3 | |
| >>> next(x_i) | |
| Traceback (most recent call last): | |
| ... | |
| StopIteration | |
| >>> x_i = list(make_points(0, 0.4, 0.1)) | |
| >>> x_i | |
| [0.1, 0.2, 0.3] |
Instead of iterating through the iterator manually, it's simpler to just cast it to a list and check the list
| ... | ||
| ValueError: h must be positive | ||
|
|
||
| >>> x_i = make_points(1,0,0.2) |
There was a problem hiding this comment.
| >>> x_i = make_points(1,0,0.2) | |
| >>> x_i = make_points(1, 0, 0.2) |
Minor formatting stuff
Describe your change:
Contributes to #9943
Checklist: