feat：bcs-helm-manager release 列表接口进一步优化 #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LidolLxf
force-pushed
the
feat_release_secret
branch
from
20114bf
to
c94f70b
Compare
adevjoe
suggested changes
Apr 1, 2024
| } | ||
|
|
||
| // 获取版本号，string->int | ||
| func getVersion(s string) int { |
| } | ||
|
|
||
| // Unix字符串转换 | ||
| func getTime(s string) time.Time { |
| bearerToken := options.GlobalOptions.Release.Token | ||
| url := fmt.Sprintf("%s/clusters/%s/api/v1/namespaces/%s/secrets?%s", apiServer, c.clusterID, option.Namespace, | ||
| "labelSelector=owner=helm,status!=superseded") | ||
| req, err := http.NewRequestWithContext(ctx, "GET", url, nil) |
There was a problem hiding this comment.
http client 使用类似 bcs-monitor 里面的 http client，有封装好的，可以移植过来
| "github.com/Tencent/bk-bcs/bcs-services/bcs-helm-manager/internal/release" | ||
| "github.com/Tencent/bk-bcs/bcs-services/bcs-helm-manager/internal/store/entity" | ||
| ) | ||
|
|
||
| func (c *cluster) list(ctx context.Context, option release.ListOption) (int, []*release.Release, error) { |
There was a problem hiding this comment.
可以新增一个 grpc 接口，和以前的 release list 接口区分开来，因为前端还没有改，先做兼容
LidolLxf
force-pushed
the
feat_release_secret
branch
2 times, most recently
from
2d26e95
to
7b885ad
Compare
adevjoe
suggested changes
Apr 17, 2024
| return nil | ||
| } | ||
|
|
||
| func (l *ListReleaseV2Action) list() (*helmmanager.ReleaseListData, error) { |
There was a problem hiding this comment.
只是拉取集群里的 release 不同，看其他的能不能复用
adevjoe
suggested changes
May 7, 2024
| package entity | ||
|
|
||
| // SecretList is a list of Secret. | ||
| type SecretList struct { |
There was a problem hiding this comment.
secret 可以引用 k8s 的库，不用 copy 一份放这里
LidolLxf
force-pushed
the
feat_release_secret
branch
from
4b46d54
to
8f71faf
Compare
LidolLxf
force-pushed
the
feat_release_secret
branch
from
8f71faf
to
92a282b
Compare
adevjoe
approved these changes
May 31, 2024
ifooth
approved these changes
May 31, 2024
wenxinlee2015
added a commit
that referenced
this pull request
Jun 4, 2024
* github-bk-bcs/master: fix: 客户端标签图表维度数据前端缓存 (#3252) fix: 修复配置项冲突计算错误 (#3249) fix: 修复客户端标签与实际不一致 (#3248) feat：bcs-monitor 删除 bcslogconfig 兼容代码 (#3241) feat：新增trace init公共方法及文件配置参数 (#3202) feat：bcs-helm-manager release 列表接口进一步优化 (#3063) fix: 客户端查询，客户端统计，批量导入问题修复 (#3247) fix: 修复导入配置模版失败 (#3246) 服务管理相关的测试问题修复 (#3245) fix: 客户端查询支持失败主类搜索以及验证空间套餐下之间的冲突 (#3243) fix: 客户端统计和批量导入bug修复 (#3244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat：bcs-helm-manager release 列表接口进一步优化