Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte-query-devtools): Replace self-closing div tag #7440

Merged
merged 2 commits into from
May 17, 2024

Conversation

o-az
Copy link
Contributor

@o-az o-az commented May 16, 2024

Svelte now warns whenever self-closing tags are used (except for ones where it's valid like <input />). This pr updates the self-closing <div /> to <div></div>. The result is that we have ones less warning in console. More reference here: sveltejs/svelte#11052

https://github.com/o-az/query/blob/a4ad0e157a0a136b6afe2bb8c60517639373fd74/packages/svelte-query-devtools/src/Devtools.svelte#L61

https://github.com/o-az/query/blob/726ca42a6a258420e609ca4c0912ae02b107b009/packages/svelte-query-devtools/src/Devtools.svelte#L61

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 0:28am

Copy link

codesandbox-ci bot commented May 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ea05cd:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@lachlancollins lachlancollins changed the title fix: replace self-closing tag in svelte devtools fix(svelte-query-devtools): Replace self-closing div tag May 17, 2024
Copy link

nx-cloud bot commented May 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6ea05cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@lachlancollins lachlancollins merged commit 23b2abe into TanStack:main May 17, 2024
6 checks passed
@o-az o-az deleted the fix-svelte-div branch May 18, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants