Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and Paste added + Shortcuts #79

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Creepler13
Copy link
Contributor

Added buttons to copy and paste the fields of entries and their shortcuts (Ctrl+C, Ctrl+V)

It would be good to add the ability to unselected selected entries by clicking at the background or other elements in order to avoid accidents.

@Creepler13 Creepler13 marked this pull request as ready for review April 28, 2024 00:05
@Loran425 Loran425 added the enhancement New feature or request label May 1, 2024
@Creepler13 Creepler13 closed this May 8, 2024
@Creepler13 Creepler13 reopened this May 8, 2024
@yedpodtrzitko
Copy link
Collaborator

when I select multiple items, it copies the fields from the first item selected only. Is that intended behaviour? Eg.

selected item 1:
tags: [foo, bar]
metatags: []

selected item 2:
tags: [aaa]
metatags: [bbb]

target item:
tags: [foo, bar]
metatags: []

Copy link
Collaborator

@yedpodtrzitko yedpodtrzitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice done overall, but there's a few things which could improve the code readability.

tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
Creepler13 and others added 2 commits May 9, 2024 11:43
Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com>
@Creepler13
Copy link
Contributor Author

when I select multiple items, it copies the fields from the first item selected only. Is that intended behaviour? Eg.

selected item 1: tags: [foo, bar] metatags: []

selected item 2: tags: [aaa] metatags: [bbb]

target item: tags: [foo, bar] metatags: []

I intended to copy the last item from the selection, but forgot the break

@CyanVoxel CyanVoxel added this to the Alpha 9.3.x milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants