Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove duplicate code for tags updating #135

Merged
merged 1 commit into from May 10, 2024

Conversation

yedpodtrzitko
Copy link
Collaborator

  • code for toggling archived and favorite tag is kinda' duplicate, plus each of these methods has some redundant code within as well.

  • use identifiers for the archived/favorite tag instead of non-descriptive int values.

@Loran425 Loran425 added the refactor Code that needs to be restructured or cleaned up label May 4, 2024
@Loran425
Copy link
Collaborator

Loran425 commented May 4, 2024

looks good

Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@CyanVoxel CyanVoxel merged commit b8d72a6 into TagStudioDev:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code that needs to be restructured or cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants