[#12588] Test coverage improvements for InstructorResponsesViewBase #13087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @justinsegawa, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
justinsegawa
changed the title
|
hi @justinsegawa, thank you for your PR, do ensure that the frontend tests pass before we proceed to review it, it appears that it's currently failing (see component tests, line 183 of per-question-view-responses.component.spec.ts is causing a failure) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12588
I created new units tests for all lines not covered in InstructorResponsesViewBase. Since this is an abstract class I wrote tests in the file per-question-view-responses.component.spec.ts, since PerQuestionViewResponsesComponent extends InstructorResponsesViewBase.