[#12779] Fix notifications update logic #13083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquestye
changed the title
cedricongjh
approved these changes
Apr 23, 2024
NicolasCwy
reviewed
Apr 23, 2024
| assert notification != null; | ||
|
|
||
| if (!notification.isValid()) { |
There was a problem hiding this comment.
Is moving the isValid check to the logic layer better? I was thinking we could leave it here. This is similar to accountDb
There was a problem hiding this comment.
It was previously suggested here. I'm not too sure which is better myself though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12779
Outline of Solution
flushAndEvicttoHibernateUtil.javaEntitiesDb#mergeto print with returned entity to overcome invalid proxy issue for entities with no persistent instance