Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Refactor FeedbackResponses and FeedbackResponseComments attributes #12791

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

[#12048] Refactor FeedbackResponses and FeedbackResponseComments attributes #12791

wants to merge 12 commits into from

Conversation

domlimm
Copy link
Contributor

@domlimm domlimm commented Feb 24, 2024 •
edited

Part of #12048. Fixes #12724

Outline of Solution

FeedbackResponses:

  • Update giver attribute to use User entity instead
  • Update recipient attribute to use User entity instead

FeedbackResponseComments:

  • Update giver attribute to use User entity instead
  • Update recipient attribute to use User entity instead
  • Update lastEditor attribute to use User entity instead

@domlimm domlimm force-pushed the v9-refactor-entities branch 5 times, most recently from 4d2f424 to b213aab Compare February 26, 2024 15:44
@domlimm domlimm added the s.Ongoing The PR is being worked on by the author(s) label Feb 27, 2024
@domlimm domlimm force-pushed the v9-refactor-entities branch 3 times, most recently from ab40081 to 424b2ab Compare March 30, 2024 04:22
@domlimm
Update giver and recipient with User entity as foreign key
6a81c89
@domlimm
Fix DataBundleLogicIT
8b1822f 
- Update test input data file
- Fix bug in incorrect parameter
- Add getUserByEmail functionality
- Reorder loading of entities to account for FK constraints
@domlimm
Fix warning with comparing giver as User to email
7e4e987
@domlimm
Update giver and last editor to User entity and update failing ITs an…
f326e08 
…d test data (partial)
@domlimm
Fix errors in tests affected thus far from attributes refactor
a750eda
@domlimm
Fix giver and recipient to return email
ae094c6
@domlimm
Fix tests (partial)
99bc6ee
@domlimm
Update getters and setters and fix lint
cde6cba
@domlimm
Add missing javadocs
2b6397f
@domlimm
Update usage of refactored attributes from FeedbackResponse entity
71c0962
@domlimm
Update usage of refactored attributes from FeedbackResponseComment
868897b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SQL Entities - User, FeedbackResponse, FeedbackResponseComment
1 participant
@domlimm