[#12048] Add test cases for Feedback response Db #12761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2024 16:52
…into feedback-response-db-test
kevin9foong
changed the title
kevin9foong
reviewed
Feb 20, 2024
| @@ -0,0 +1,130 @@ | |||
| package teammates.storage.sqlapi; | |||
There was a problem hiding this comment.
nice work splitting the TCs!
weiquu
approved these changes
Feb 21, 2024
|
|
||
| feedbackResponsesDb.createFeedbackResponse(feedbackResponse); | ||
|
|
||
| mockHibernateUtil.verify(() -> HibernateUtil.persist(feedbackResponse)); |
There was a problem hiding this comment.
Is there a reason for not also adding the times(1)? Same question for testUpdateFeedbackResponse_feedbackResponseExists_success() and testDeleteFeedbackResponse_feedbackResponseExists_success() below - not sure if I missed something since other methods use that
cedricongjh
requested changes
Feb 21, 2024
Comment on lines
+103
to
+112
| public void testUpdateFeedbackResponse_feedbackResponseDoesNotExist_throwsEntityDoesNotExistException() { | ||
| FeedbackResponse feedbackResponse = getTypicalFeedbackResponse(); | ||
|
|
||
| mockHibernateUtil.when(() -> HibernateUtil.get(FeedbackResponse.class, feedbackResponse.getId())) | ||
| .thenReturn(null); | ||
|
|
||
| assertThrows(EntityDoesNotExistException.class, | ||
| () -> feedbackResponsesDb.updateFeedbackResponse(feedbackResponse)); | ||
| mockHibernateUtil.verify(() -> HibernateUtil.merge(feedbackResponse), never()); | ||
| } |
There was a problem hiding this comment.
let's add a test case for invalid parameters exception as well
Comment on lines
+54
to
+64
| public void testCreateFeedbackResponse_feedbackResponseAlreadyExists_throwsEntityAlreadyExistsException() { | ||
| FeedbackResponse feedbackResponse = getTypicalFeedbackResponse(); | ||
|
|
||
| mockHibernateUtil.when(() -> HibernateUtil.get(FeedbackResponse.class, feedbackResponse.getId())) | ||
| .thenReturn(feedbackResponse); | ||
|
|
||
| assertThrows(EntityAlreadyExistsException.class, () -> feedbackResponsesDb.createFeedbackResponse(feedbackResponse)); | ||
|
|
||
| mockHibernateUtil.verify(() -> HibernateUtil.get(FeedbackResponse.class, feedbackResponse.getId())); | ||
| mockHibernateUtil.verify(() -> HibernateUtil.persist(feedbackResponse), never()); | ||
| } |
There was a problem hiding this comment.
let's create a test case for throwing invalid parameters exception as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Add test cases for FeedbackResponseDb