Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/integrations #2061

Conversation

kartik4949
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@kartik4949 kartik4949 changed the base branch from main to feature/flatten_serialization May 16, 2024 21:02
@jieguangzhou jieguangzhou force-pushed the feature/flatten_serialization branch 4 times, most recently from dd9bf63 to 95cec4e Compare May 17, 2024 08:16
parts=self.parts + [('__gt__', (other,), {})],
)

def __le__(self, other):
Copy link
Collaborator

@blythed blythed May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will have issues parsing t.select(t.brand == 'Nike'), for example. This will require a bit of string wrangling.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it, it worked.

Copy link
Collaborator

@blythed blythed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear why we need to add _schema to the Schema? Maybe you can explain a bit? I would rather say, on insertion, a MongoDB document can optionally specify a _schema, or fall back to the default.

@kartik4949 kartik4949 merged commit bb690fe into SuperDuperDB:feature/flatten_serialization May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants