-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/integrations #2061
Fix/integrations #2061
Conversation
dd9bf63
to
95cec4e
Compare
64f7fb8
to
0bc6fb4
Compare
b88b9a3
to
546126d
Compare
752e20c
to
d15f382
Compare
parts=self.parts + [('__gt__', (other,), {})], | ||
) | ||
|
||
def __le__(self, other): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have issues parsing t.select(t.brand == 'Nike')
, for example. This will require a bit of string wrangling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it, it worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear why we need to add _schema
to the Schema
? Maybe you can explain a bit? I would rather say, on insertion, a MongoDB document can optionally specify a _schema
, or fall back to the default.
Description
Related Issues
Checklist
make unit_testing
andmake integration-testing
successfully?Additional Notes or Comments