Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common action updates #12017

Merged
merged 2 commits into from
May 21, 2024
Merged

Common action updates #12017

merged 2 commits into from
May 21, 2024

Conversation

sarahill
Copy link
Contributor

Added guidance for add actions to not open a modal before adding/creation of a resource.

Screenshot 2024-05-17 at 5 33 57 PM

@sarahill sarahill merged commit b54975a into main May 21, 2024
8 checks passed
@sarahill sarahill deleted the common-action-updates branch May 21, 2024 15:09
laurkim pushed a commit that referenced this pull request Jun 3, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@13.5.0

### Minor Changes

- [#12118](#12118)
[`5fcca651f`](5fcca65)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added transition
delay to Collapsible

### Patch Changes

- Updated dependencies
\[[`fe2891792`](fe28917)]:
    -   @shopify/polaris-icons@9.1.1

## @shopify/polaris-icons@9.1.1

### Patch Changes

- [#12169](#12169)
[`fe2891792`](fe28917)
Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated XIcon SVG
path to correct size

## polaris.shopify.com@1.0.7

### Patch Changes

- [#12191](#12191)
[`82f8a0dcd`](82f8a0d)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
guidelines add example


- [#12017](#12017)
[`b54975aef`](b54975a)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
pattern guidance for add actions

- Updated dependencies
\[[`5fcca651f`](5fcca65),
[`fe2891792`](fe28917)]:
    -   @shopify/polaris@13.5.0
    -   @shopify/polaris-icons@9.1.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants