Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue leader failed should close leader component #56

Merged
merged 2 commits into from
May 20, 2024

Conversation

yannan
Copy link
Contributor

@yannan yannan commented May 10, 2024

多副本情况下,某副本作为leader续期失败之后,其作为leader的相关component没有关闭。导致多个副本会同时执行相关任务,直观表现为会存在多个dispatch和watchdog同时执行

Copy link
Contributor Author

@yannan yannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.31%. Comparing base (e6c7544) to head (369e880).
Report is 1 commits behind head on master.

❗ Current head 369e880 differs from pull request most recent head ab356e3. Consider uploading reports for the commit ab356e3 to get more accurate results

Files Patch % Lines
fastflow.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   60.02%   60.31%   +0.28%     
==========================================
  Files          28       28              
  Lines        2972     2986      +14     
==========================================
+ Hits         1784     1801      +17     
+ Misses       1045     1043       -2     
+ Partials      143      142       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShiningRush
Copy link
Owner

ShiningRush commented May 13, 2024

@yannan 代码没问题,还麻烦补充下关于LeaderChangedHandler close 逻辑的单元测试

@ShiningRush ShiningRush merged commit 6e8a32c into ShiningRush:master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants