Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node-gcm deprecation #32450

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: node-gcm deprecation #32450

merged 1 commit into from
May 20, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented May 17, 2024

Backport of #32208

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner May 17, 2024 14:15
@dionisio-bot dionisio-bot bot requested a review from Gustrb May 17, 2024 14:15
Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: e00098c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented May 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Gustrb
Gustrb previously approved these changes May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.44%. Comparing base (b14dd7c) to head (e00098c).
Report is 1 commits behind head on release-6.5.7.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.5.7   #32450      +/-   ##
=================================================
+ Coverage          47.06%   52.44%   +5.37%     
=================================================
  Files                764      813      +49     
  Lines              14572    15225     +653     
  Branches            2768     2863      +95     
=================================================
+ Hits                6859     7984    +1125     
+ Misses              7319     6806     -513     
- Partials             394      435      +41     
Flag Coverage Δ
e2e 48.73% <ø> (+6.38%) ⬆️
unit 70.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 20, 2024
@ggazzo ggazzo added this to the 6.5 milestone May 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 20, 2024
@ggazzo ggazzo merged commit c6e07dd into release-6.5.7 May 20, 2024
45 checks passed
@ggazzo ggazzo deleted the backport-6.5.7-32208 branch May 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants