fix: sidebar last message E2EE

[hugocostadev]

Proposed changes (including videos or screenshots)

If End-to-End Encryption is enabled and you delete the last message in a room the is updated to the last message without a type (t) attribute set which will be last message before the encryption was enabled for this room or no message if no unencrypted message is available.

If you send an encrypted message the lastMessage is updated correctly but on deletion the method Rooms.resetLastMessageById is called which will get the last message by calling Messages.getLastVisibleMessageSentWithNoTypeByRoomId. But an e2e message has the t set to "e2e" and will be ignored.

I did:

• renamed Messages.getLastVisibleMessageSentWithNoTypeByRoomId function to Messages.getLastVisibleUserMessageSentByRoomId
• add a query to include e2e type of messages
• added a end-to-end test

Issue(s)

Steps to test or reproduce

1. Enable End-to-End Encryption in Settings
2. Start a new room (no matter which type)
3. Enable encryption for this room
4. Write multiple messages with different content
5. Last message will be shown on the left side (Expanded view)
6. Delete the last message
7. Reload the page if the message on the left side is not updating
8. Find the wrong last message in the preview on the left.

Expected behavior:

The last message is shown nevermind if its an encrypted or unencrypted message

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-12

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: b5b820c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/models	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
rocketchat-services	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/presence	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (4b8c215) to head (b5b820c).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32431      +/-   ##
===========================================
- Coverage    55.81%   55.64%   -0.17%     
===========================================
  Files         2413     2408       -5     
  Lines        53160    53020     -140     
  Branches     10925    10901      -24     
===========================================
- Hits         29669    29503     -166     
- Misses       20871    20905      +34     
+ Partials      2620     2612       -8     

Flag	Coverage Δ
e2e	55.18% <ø> (+0.12%)	⬆️
unit	72.88% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[yash-rajpal]

LGTM!