Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new navigation with NavBar #32382

Draft
wants to merge 41 commits into
base: develop
Choose a base branch
from
Draft

feat: new navigation with NavBar #32382

wants to merge 41 commits into from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 7, 2024

SIDE-35

epic tasks:

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 0551411

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.34%. Comparing base (bbb92fc) to head (eff97aa).
Report is 2 commits behind head on develop.

Current head eff97aa differs from pull request most recent head 0551411

Please upload reports for the commit 0551411 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32382      +/-   ##
===========================================
- Coverage    56.36%   56.34%   -0.02%     
===========================================
  Files         2433     2435       +2     
  Lines        53702    53668      -34     
  Branches     11061    11057       -4     
===========================================
- Hits         30267    30240      -27     
- Misses       20787    20810      +23     
+ Partials      2648     2618      -30     
Flag Coverage Δ
unit 72.91% <86.20%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/client/sidebar/header/SearchSection.tsx Outdated Show resolved Hide resolved
apps/meteor/client/NavBar/NavBar.tsx Outdated Show resolved Hide resolved
apps/meteor/client/NavBar/Omnichannel/OmnichannelQueue.tsx Outdated Show resolved Hide resolved
apps/meteor/client/NavBar/actions/DirectoryPage.tsx Outdated Show resolved Hide resolved
apps/meteor/client/NavBar/actions/HomePage.tsx Outdated Show resolved Hide resolved
apps/meteor/client/NavBar/actions/MarketPlaceMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/sidebar/header/EditStatusModal.tsx Outdated Show resolved Hide resolved
@dougfabris
Copy link
Member

The NavBar alignment is different and kinda weird in the header of the pages in the mobile view

Screenshot 2024-05-29 at 16 31 59

@dougfabris
Copy link
Member

dougfabris commented May 29, 2024

Additionally, I found small issues using RTL language:

Kapture 2024-05-29 at 16 38 12

@juliajforesti juliajforesti force-pushed the feat/navbar branch 3 times, most recently from f1e24a8 to 1e9602b Compare June 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants