MOD-6534: Missing values indexing - Add support to indexing pipeline #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
raz-mon
reviewed
May 20, 2024
src/redisearch_api.c
Outdated
| @@ -44,6 +44,7 @@ RefManager* RediSearch_CreateIndex(const char* name, const RSIndexOptions* optio | |||
| IndexSpec* spec = NewIndexSpec(name); | |||
| StrongRef ref = StrongRef_New(spec, (RefManager_Free)IndexSpec_Free); | |||
| IndexSpec_MakeKeyless(spec); | |||
| spec->missingFieldDict = dictCreate(&dictTypeHeapStrings, NULL); | |||
There was a problem hiding this comment.
Add to IndexSpec_MakeKeyless()
src/fork_gc.c
Outdated
| RedisSearchCtx_UnlockSpec(sctx); | ||
| StrongRef_Release(spec_ref); | ||
| } | ||
|
|
raz-mon
merged commit 5aa4ede
into
feature_missing_values_indexing
6 of 7 checks passed
raz-mon
pushed a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of what the PR is solving, including:
Which issues this PR fixes
Main objects this PR modified
Mark if applicable