Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD-7025: Avoid expansion/stemming from numeric values #4636

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

nafraf
Copy link
Collaborator

@nafraf nafraf commented May 11, 2024

Description

Avoid the expansion of numeric values and terms which include numbers.
The change affects DIALECT 2 and DIALECT 5

Previous behavior:

FT.CREATE idx schema t text

127.0.0.1:6379> FT.EXPLAINCLI idx 12.3 dialect 5
1) UNION {
2)   12.3
3)   +12.3(expanded)
4) }

127.0.0.1:6379> FT.explaincli idx cherry2 dialect 5
1) UNION {
2)   cherry2
3)   +cherry2(expanded)
4) }

127.0.0.1:6379> FT.explaincli idx $param dialect 5 PARAMS 2 param inf
1) UNION {
2)   inf
3)   +inf(expanded)
4) }
5)

New behavior:

127.0.0.1:6379> FT.EXPLAINCLI idx 12.3 dialect 5
1) 12.3

127.0.0.1:6379> FT.explaincli idx cherry2 dialect 5
1) cherry2

127.0.0.1:6379> FT.explaincli idx $param dialect 5 PARAMS 2 param inf
1) inf
2)

Which issues this PR fixes

  1. MOD-7025

Main objects this PR modified

  1. parser/v2
  2. parser/v3

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

nafraf and others added 30 commits April 18, 2024 04:59
@nafraf nafraf marked this pull request as ready for review May 14, 2024 20:54
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.17%. Comparing base (10261d2) to head (e206755).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4636      +/-   ##
==========================================
- Coverage   86.18%   86.17%   -0.01%     
==========================================
  Files         190      190              
  Lines       34508    34538      +30     
==========================================
+ Hits        29739    29764      +25     
- Misses       4769     4774       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf requested a review from oshadmi May 14, 2024 21:53
@nafraf nafraf changed the title Avoid expansion/stemming from numeric values MOD-7025: Avoid expansion/stemming from numeric values May 14, 2024
Base automatically changed from nafraf_parser-v3-punct to master May 16, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant