RSValue array cleanup - [MOD-7145] #4612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4612 +/- ##
==========================================
- Coverage 86.26% 86.25% -0.02%
==========================================
Files 190 190
Lines 34847 34828 -19
==========================================
- Hits 30061 30040 -21
- Misses 4786 4788 +2 ☔ View full report in Codecov by Sentry. |
DvirDukhan
reviewed
Jun 3, 2024
DvirDukhan
reviewed
Jun 6, 2024
| * Helper function to allocate memory before passing it to RSValue_NewArray | ||
| */ | ||
| static inline RSValue **RSValue_AllocateArray(uint32_t len) { | ||
| return (RSValue **)rm_malloc(len * sizeof(RSValue *)); |
There was a problem hiding this comment.
Don’t we care about the performance difference? In all the places we fill the entire array anyway. This is not a partially initialized struct but an array of pointers.
I added a memset call in the only place we might not fill the array (and in this case it also most likely a but in the trieMap or its iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Remove unnecessary initialization and branching, as we almost exclusively were calling
RSValue_NewArrayEx(arr, len, RSVAL_ARRAY_NOINCREF | RSVAL_ARRAY_ALLOC);(with these flags), and in the few cases we don't we can get the same behavior with minor adjustments.We can then delete
RSValue_NewArrayExand useRSValue_NewArraythat gives the same behavior as the prior call with the commonly used flags, without branching and no-op loopsMark if applicable