Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] updating legacy index API sorting.md #3930

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adrianoamaral
Copy link
Collaborator

updating the code example from the legacy FT.ADD to simple HSET, and fix some bugs

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. The current state briefly
  2. What is the change
  3. Adding the outcome (changed state)

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

updating the code example from the legacy FT.ADD to simple HSET, and fix some bugs
@adrianoamaral adrianoamaral changed the title updating legacy index API sorting.md [DOC] updating legacy index API sorting.md Oct 11, 2023
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are probably more places in our docs where we use ft.add and other deprecated commands, consider changing these in this PR as well


# Searching while sorting

# Searching by last name and sorting by first name
> FT.SEARCH users "@last_name:jones" SORTBY first_name DESC

# Searching by both first and last name, and sorting by age
> FT.SEARCH users "alice jones" SORTBY age ASC
> FT.SEARCH users "jones" SORTBY age ASC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compound names didn't work int his example

@dwdougherty
Copy link
Collaborator

Changes LGTM.

Copy link

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 30, 2023
@dwdougherty
Copy link
Collaborator

The changes in this PR will be merged to the new docs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants