Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve phy interface driver #8731

Merged
merged 1 commit into from
May 29, 2024
Merged

improve phy interface driver #8731

merged 1 commit into from
May 29, 2024

Conversation

jiadingxu
Copy link
Contributor

Current issue:
The current rt_phy_ops API can not specify phy in multi-phy case

Solution:
Add one parameter phy to specify phy instance

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@jiadingxu jiadingxu marked this pull request as draft April 7, 2024 01:25
@jiadingxu jiadingxu marked this pull request as ready for review April 7, 2024 01:27
BernardXiong
BernardXiong requested changes Apr 7, 2024
View reviewed changes
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意代码风格

@Rbb666
Copy link
Contributor

Rbb666 commented Apr 7, 2024 •
edited

@jiadingxu 可以使用这个python脚本格式化下：https://github.com/mysterywolf/formatting

@Rbb666 Rbb666 requested a review from BernardXiong April 7, 2024 05:32
@jiadingxu
Copy link
Contributor Author

@jiadingxu 可以使用这个python脚本格式化下：https://github.com/mysterywolf/formatting

谢谢，后面如果有提交，会预先执行一次。

@jiadingxu jiadingxu marked this pull request as draft April 7, 2024 10:15
@jiadingxu jiadingxu marked this pull request as ready for review April 10, 2024 06:42
mysterywolf
mysterywolf previously requested changes Apr 16, 2024
View reviewed changes
components/drivers/include/drivers/phy.h Outdated Show resolved Hide resolved
components/drivers/include/drivers/phy.h Show resolved Hide resolved
@mysterywolf mysterywolf marked this pull request as draft April 18, 2024 02:47
@jiadingxu
[components][drivers][include][phy] add one more parameter for muliti…
62ac06f 
…ple phys

- add parameter phy to specify multiple-phy instance

Signed-off-by: Jiading Xu <Jiading.Xu@hpmicro.com>
@jiadingxu jiadingxu marked this pull request as ready for review April 18, 2024 03:38
@mysterywolf mysterywolf marked this pull request as draft April 19, 2024 02:11
@jiadingxu jiadingxu marked this pull request as ready for review April 19, 2024 02:16
@Rbb666 Rbb666 requested a review from mysterywolf April 24, 2024 08:55
@mysterywolf
Copy link
Member

我没有看懂 这个PR的代码在哪里使用了 增加了一个参数，然后全都赋值为NULL

@mysterywolf mysterywolf added the discussion This PR/issue needs to be discussed later label May 4, 2024
@Rbb666 Rbb666 self-requested a review May 14, 2024 07:36
@jiadingxu
Copy link
Contributor Author

我没有看懂 这个PR的代码在哪里使用了 增加了一个参数，然后全都赋值为NULL
您好！我来自HPMicro,这次PR的主要目的是为双网口/双以太网PHY做准备，待此次PR合入后，HPMirco 最新BSP的demo(包含双网口)也即将提交PR至RTThread。

@jiadingxu
Copy link
Contributor Author

@Rbb666 @mysterywolf @BernardXiong 各位好！我们HPM后面的基于双网口的PR会依赖的当前这个PR。

@Rbb666
Copy link
Contributor

Rbb666 commented May 28, 2024

@BernardXiong 熊大你看下这个PR，没问题就合并了吧

@BernardXiong BernardXiong removed the discussion This PR/issue needs to be discussed later label May 29, 2024
@Rbb666 Rbb666 dismissed mysterywolf’s stale review May 29, 2024 14:22

此PR没有问题

@Rbb666 Rbb666 merged commit 2fcf151 into RT-Thread:master May 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernardXiong BernardXiong BernardXiong approved these changes

@Rbb666 Rbb666 Rbb666 approved these changes

@mysterywolf mysterywolf Awaiting requested review from mysterywolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jiadingxu @CLAassistant @Rbb666 @mysterywolf @BernardXiong