fix: move continue and skip buttons higher up the page #22342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃摳 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 1.05 MB 鈩癸笍 View Unchanged
|
|
Less than an hour after my feedback there is a fix, wow!! Thank you |
zlwaterfield
approved these changes
May 20, 2024
馃摳 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
馃摳 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
timgl
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continue button for SDKs instructions were getting pushed far down the page because the list of SDKs is so long (we should consider making this shorter in some way).
Image from customer:
Changes
Moves the button to be next to the verify installation bit.
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Ya
How did you test this code?
馃憖