feat: remove most frontend references to available_features #22337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @xrdt! 馃憢 |
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -28 B (0%) Total Size: 1.05 MB 鈩癸笍 View Unchanged
|
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
xrdt
force-pushed
the
by/deprecate-available-features
branch
from
e099ce4
to
9a4ee34
Compare
馃摳 UI snapshots have been updated22 snapshot changes in total. 0 added, 22 modified, 0 deleted:
Triggered by this commit. |
|
The experiments test keeps failing. I've asked for guidance about it on this PR: #22339 |
馃摳 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
馃摳 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
timgl
pushed a commit
that referenced
this pull request
May 21, 2024
* remove most frontend references to available_features * some more * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * adding back some items, fix tests * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix test * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
* remove most frontend references to available_features * some more * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * adding back some items, fix tests * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * fix test * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm going to deprecate this in stages. This PR mainly removed frontend references to available_features and switched to using hasAvailableFeature when feature checks are necessary.
The next PR will handle the backend side of references to available_features.
The final PR will remove the database fields.
Changes
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?