feat: sort the simple key value list #22335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +240 B (+0.02%) Total Size: 1.05 MB ℹ️ View Unchanged
|
daibhin
approved these changes
May 17, 2024
Comment on lines
+30
to
+33
| const promotedItems = promotedKeys?.length ? sortedItems.filter(([key]) => promotedKeys.includes(key)) : [] | ||
| const nonPromotedItems = promotedKeys?.length | ||
| ? sortedItems.filter(([key]) => !promotedKeys.includes(key)) | ||
| : sortedItems |
There was a problem hiding this comment.
Some type of partition method would be cool but I don't think we have one
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
pauldambra
commented
May 18, 2024
frontend/src/scenes/session-recordings/player/inspector/components/SimpleKeyValueList.tsx
Outdated
Show resolved
Hide resolved
…ents/SimpleKeyValueList.tsx
pauldambra
commented
May 18, 2024
frontend/src/scenes/session-recordings/player/inspector/components/SimpleKeyValueList.tsx
Outdated
Show resolved
Hide resolved
…ents/SimpleKeyValueList.tsx
timgl
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the #mykologs hackathon
Sorting the simple key value list was surprisingly amazing
This also lets the caller promote particular properties