Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hedgehog Mode 2.0 #22334

Merged
merged 44 commits into from
May 21, 2024
Merged

feat: Hedgehog Mode 2.0 #22334

merged 44 commits into from
May 21, 2024

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented May 16, 2024

Problem

I wanted to do HedgehogMode 2.0 as a hackathon. Nobody else did :(

Then I was on a flight with no wifi and thought - I'LL MAKE MY OWN HACKATHON. And here we are

Changes

2024-05-21 10 24 45

Profile picture
Screenshot 2024-05-21 at 09 36 01

  • Adds a hedgehog_config to the user
  • Adds a settings area for the user for hedgehog mode
  • All settings are now peristed to the remote state
  • Adds different colors
  • Removes dark mode (replaced by colors)
  • Created a Profile component used to render a configured hedgehog
  • Adds an option to use this as your profile image
  • Adds Party Mode

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Extensive play-testing

@benjackwhite benjackwhite changed the title feat: Persistent customization of hedgehogmode feat: Hedgehog Mode 2.0 May 16, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented May 21, 2024

Size Change: +1.86 kB (+0.18%)

Total Size: 1.05 MB

Filename Size Change
frontend/dist/toolbar.js 1.05 MB +1.86 kB (+0.18%)

compressed-size-action

@pauldambra
Copy link
Member

2.0!! that's 1500x less than Hedgehog Mode 3000. what are you thinking?! 🤣

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Works well other than the couple of things mentioned. Feel free to ship and follow up if there's anything you want to change - conscious this is already a large PR

@benjackwhite benjackwhite merged commit ed25f62 into master May 21, 2024
84 checks passed
@benjackwhite benjackwhite deleted the feat/hedgehog-persistence branch May 21, 2024 13:17
thmsobrmlr pushed a commit that referenced this pull request May 21, 2024
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This is the next level of PostHog

@Twixes
Copy link
Collaborator

Twixes commented May 21, 2024

My only suggestion would be to make the background behind the hedgehog profile picture transparent and border-less

timgl pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants