-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use toBlob not toDataUrl #22317
Conversation
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Problem
https://posthoghelp.zendesk.com/agent/tickets/13270
A customer reported that their transparent canvas had a black background during playback.
This is because we switched to
image/jpeg
in #21944 to take advantage of compression so larger canvas elements did not block the main thread and freeze customers tabs.Sadly JPEG doesn't allow transparency :/
Changes
Turns out that
toDataUrl
is just inherently slow.toBlob
is asynchronous and much faster so it doesn't block the UI thread.It is supported on all browsers so let's use that instead.
I specifically left out the compression this time because by the sounds of things this change will already be a sufficient speed bump
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran a canvas recording locally and everything looked fine