feat: Improved toolbar authentication (with support for CLI) #22295

benjackwhite · 2024-05-15T15:31:19Z

Problem

For the CLI hackathon - adds a secure flow for passing a jwt to the cli to be used.

The outcome of this made me think that we could use this for the toolbar as well, improving the auth flow for it and potentially allowing solutions that don't work well with the hash param state (via posthog.loadToolbar() )

WARNING - As this is auth related we should think slowly before we merge. For now we can demo the tool on this PR.

Changes

Adds a new auth flow for exhanging a token in a non-interactive way
Removes TemporaryTokenAuthentication in favour of the new JWT based flow

TODO

Add scopes support to the token generation
Add scopes to the authorizer redirect
Load projects from the API so that we can correctly get the projectId for a given token

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

# Conflicts: # posthog/api/user.py

# Conflicts: # posthog/urls.py

posthog/api/client_auth.py

# Conflicts: # posthog/api/__init__.py # posthog/api/client_auth.py # posthog/api/routing.py # posthog/jwt.py # posthog/urls.py

marandaneto · 2024-05-22T10:56:52Z

I will close #22321 in favor of this one

# Conflicts: # posthog/models/user.py

posthog-bot · 2024-05-23T15:23:19Z

📸 UI snapshots have been updated

12 snapshot changes in total. 0 added, 12 modified, 0 deleted:

chromium: 0 added, 12 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2024-05-23T15:32:19Z

Size Change: +1.1 kB (+0.1%)

Total Size: 1.06 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	1.06 MB	+1.1 kB (+0.1%)

_{compressed-size-action}

posthog-bot · 2024-05-31T07:31:01Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

# Conflicts: # frontend/__snapshots__/scenes-other-settings--settings-session-timeout-password-only--dark.png # frontend/__snapshots__/scenes-other-settings--settings-session-timeout-password-only--light.png # frontend/src/scenes/urls.ts # posthog/permissions.py

posthog-bot · 2024-05-31T08:31:00Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-31T09:33:08Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-31T09:43:08Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-31T11:45:01Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-05-31T11:56:24Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Added cli flow

67d86b7

benjackwhite requested review from marandaneto and danielxnj May 15, 2024 15:31

benjackwhite added 3 commits May 15, 2024 18:39

Fix jwt auth finally?

d32fa09

Fixes

82bd68e

Fix

e8b8637

danielxnj added the deploy label May 15, 2024

Merge branch 'master' into feat/cli-auth

7a2de97

github-actions bot temporarily deployed to pr-feat/cli-auth May 15, 2024 16:25 Destroyed

Merge branch 'master' into feat/cli-auth

8743bae

# Conflicts: # posthog/api/user.py

github-actions bot temporarily deployed to pr-feat/cli-auth May 21, 2024 11:21 Destroyed

benjackwhite added 5 commits May 21, 2024 14:29

Refactored logic for handling the cli auth

b498146

Fixed up scene

5aa8729

Fix

6396650

Added rate limiting

6492935

Remove todo

d1829e4

github-actions bot deployed to pr-feat/cli-auth May 21, 2024 13:12 View deployment

benjackwhite removed the deploy label May 22, 2024

benjackwhite added 4 commits May 22, 2024 10:29

Merge branch 'master' into feat/cli-auth

e3162b9

# Conflicts: # posthog/urls.py

Fix

32c9cc6

Fix

3e07b2d

Fixes

305cbfa

marandaneto reviewed May 22, 2024

View reviewed changes

posthog/api/client_auth.py Show resolved Hide resolved

benjackwhite removed the request for review from danielxnj May 22, 2024 09:18

benjackwhite added 5 commits May 22, 2024 11:56

wip

4838600

fix

1722b58

Merge branch 'feat/toolbar-auth-v2' into feat/cli-auth

2ac59d1

# Conflicts: # posthog/api/__init__.py # posthog/api/client_auth.py # posthog/api/routing.py # posthog/jwt.py # posthog/urls.py

Fixes

47f248f

Swapped over to using access token

d5ef83c

benjackwhite and others added 7 commits May 22, 2024 13:39

Fixed up auth flow

2fdbb94

Commit some stuff

efb6de3

Merge branch 'master' into feat/cli-auth

fd5c93d

# Conflicts: # posthog/models/user.py

Update query snapshots

fa80665

Update query snapshots

a101a0a

Update query snapshots

4329ff8

Update UI snapshots for chromium (1)

cbdc8d1

github-actions bot and others added 2 commits May 23, 2024 15:33

Update query snapshots

fe74027

Fix up auth

a123dcb

posthog-bot added the stale label May 31, 2024

benjackwhite removed the stale label May 31, 2024

benjackwhite and others added 2 commits May 31, 2024 09:20

Update UI snapshots for chromium (1)

cb2338a

benjackwhite and others added 2 commits May 31, 2024 10:23

Fix up api calls

b966fdb

Update UI snapshots for chromium (1)

340005d

Update UI snapshots for chromium (1)

09f016d

benjackwhite and others added 5 commits May 31, 2024 11:54

Fixes

c382964

Added scopes

7646c2b

Added scopes to api key validation

23f3295

Added more scopes

83398b0

Update UI snapshots for chromium (2)

6c600aa

Update UI snapshots for chromium (2)

4d8bfa2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Improved toolbar authentication (with support for CLI) #22295

feat: Improved toolbar authentication (with support for CLI) #22295

benjackwhite commented May 15, 2024 •

edited

marandaneto commented May 22, 2024

posthog-bot commented May 23, 2024

github-actions bot commented May 23, 2024 •

edited

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

feat: Improved toolbar authentication (with support for CLI) #22295

Are you sure you want to change the base?

feat: Improved toolbar authentication (with support for CLI) #22295

Conversation

benjackwhite commented May 15, 2024 • edited

Problem

Changes

TODO

Does this work well for both Cloud and self-hosted?

How did you test this code?

marandaneto commented May 22, 2024

posthog-bot commented May 23, 2024

📸 UI snapshots have been updated

github-actions bot commented May 23, 2024 • edited

posthog-bot commented May 31, 2024

posthog-bot commented May 31, 2024

📸 UI snapshots have been updated

posthog-bot commented May 31, 2024

📸 UI snapshots have been updated

posthog-bot commented May 31, 2024

📸 UI snapshots have been updated

posthog-bot commented May 31, 2024

📸 UI snapshots have been updated

posthog-bot commented May 31, 2024

📸 UI snapshots have been updated

benjackwhite commented May 15, 2024 •

edited

github-actions bot commented May 23, 2024 •

edited