Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Components - greenhouse #11886

Merged
merged 9 commits into from
May 20, 2024
Merged

New Components - greenhouse #11886

merged 9 commits into from
May 20, 2024

Conversation

luancazarine
Copy link
Collaborator

Resolves #11589.

@luancazarine luancazarine added the ai-assisted Content generated by AI, with human refinement and modification label May 8, 2024
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 3:01pm
pipedream-docs ⬜️ Ignored (Inspect) May 17, 2024 3:01pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) May 17, 2024 3:01pm

Sources
 - Watch Candidates (Instant)
 - New Candidate Application
 - New Scheduled Interview

Actions
 - Create Candidate
 - Create Prospect
 - Add Attachment To Candidate
@GTFalcao
Copy link
Collaborator

@luancazarine PR is still marked as a draft - is it ready for review?

@luancazarine luancazarine marked this pull request as ready for review May 13, 2024 13:36
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one suggestion to avoid code repetition, and also one package/config comment.

components/greenhouse/actions/common/base-create.mjs Outdated Show resolved Hide resolved
components/greenhouse/package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some components can still be optimized to avoid repeating code, but I'll move this forward to QA since this has no impact on functionality

@luancazarine
Copy link
Collaborator Author

/approve

@luancazarine luancazarine merged commit 8ec1282 into master May 20, 2024
11 checks passed
@luancazarine luancazarine deleted the issue-11589 branch May 20, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai-assisted Content generated by AI, with human refinement and modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Components] greenhouse
2 participants