explicitly call EnsurePullability while adding tables #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| if err := ensurePullabilityFuture.Get(ctx, nil); err != nil { | ||
| w.logger.Error("failed to ensure pullability for additional tables: ", err) | ||
| return err |
There was a problem hiding this comment.
Can this be return nil?
There was a problem hiding this comment.
processCDCFlowConfigUpdates return value should not be aborting whole workflow. Any flow config update error should result in an error being reported to user in some way, & then being ignored. Then this can remain return err
serprex
reviewed
Feb 15, 2024
heavycrystal
force-pushed
the
dynadd-ensure-pullability
branch
from
c9dd1c0
to
97a23c7
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI for dynamic table addition should prevent tables that we cannot mirror via CDC [no primary key + replident != full] to be selected. However, we end up using the signal for adding tables sometimes, and currently there is no check in this codepath.
Invoking
EnsurePullabilityexplicitly to guard against this.