Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not escaped / in filename for the ability to specify directories #296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theotheo
Copy link

@theotheo theotheo commented Jan 22, 2024

Hello!
I'm trying to sync Zotero and Obsidian, so I decided to give your project a try. Thanks for developing it!

However, personally, I found the lack of the ability to create directories according to a template. Issue #207 showed that I'm not alone in this. Code exploration suggested that this could be achieved with minimal changes. So, I decided to create this pull request (PR).

P.S.

I had never dealt with rushjs before. So, in the end, exploring and modifying the code took 10 minutes, but the build took 2 and a half hours for some reason! It seemed like I was missing some packages. I don't know how much value my observations on this matter hold for you. But for example, I had to do this:

rush add -p esbuild-sass-plugin
rush add -p @preact/signals-core

And something wrong with ophidian-lib-core submodule.

At the end I was not able to run the production build as well, but I'm currently using the development build.

P.P.S.

Yes, I saw that you mentioned it's not simple and that's indeed true :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant