Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes are not displayed #311

Open
asan-emirsaleh opened this issue Feb 9, 2024 · 5 comments
Open

Notes are not displayed #311

asan-emirsaleh opened this issue Feb 9, 2024 · 5 comments

Comments

@asan-emirsaleh
Copy link

asan-emirsaleh commented Feb 9, 2024

Hello!
I have recently encountered an interesting issue: While processing references with notes in Obsidian and inspecting available fields in template customization window , no notes appear in the JSON schema under the neither in the "notes" nor attachments fields.
@aidenlx could you please check if there are schema incompatibility issues? According to this forum post notes are stored in ItemNotes table.

Best regards
Asan

@asan-emirsaleh
Copy link
Author

Update: I have checked the zotero.sqlite. It does content notes. And the schema did not changed in the most recent Zotero beta. But I noticed that there are different behaviors in different setups:

  • the latest Obsidian, Zotero v7.0.0-beta.54+6b996d4f9: Notes are available for Zotlit and could be rendered in md.
  • the latest Obsidian and the latest Zotero: Notes are not available for Zotlit, and the "notes" field in the template editor is represented by an empty array.
    Screenshot from 2024-02-18 13-03-58
    The other fields but "notes" possess data in the JSON schema inside the template editor.

@asan-emirsaleh
Copy link
Author

asan-emirsaleh commented Feb 26, 2024

The issue seems to be related to #272
I have a note with some highlights coloured using Zotero-provided colour highlighting feature.
Screenshot from 2024-02-26 17-24-54
This is possibly the cause of the error in notes schema constructing:
Screenshot from 2024-02-26 17-21-38

plugin:zotlit:359 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'renderColored')
    at Object.replacement (plugin:zotlit:359:37939)
    at k.D (turndown.js:2:9551)
    at turndown.js:2:9210
    at NodeList.reduce (<anonymous>)
    at k.b (turndown.js:2:9059)
    at k.D (turndown.js:2:9459)
    at turndown.js:2:9210
    at NodeList.reduce (<anonymous>)
    at k.b (turndown.js:2:9059)
    at k.D (turndown.js:2:9459)
replacement @ plugin:zotlit:359
D @ turndown.js:2
(anonymous) @ turndown.js:2
b @ turndown.js:2
D @ turndown.js:2
(anonymous) @ turndown.js:2
b @ turndown.js:2
D @ turndown.js:2
(anonymous) @ turndown.js:2
b @ turndown.js:2
D @ turndown.js:2
(anonymous) @ turndown.js:2
b @ turndown.js:2
turndown @ turndown.js:2
turndown @ plugin:zotlit:359
normalizeNotes @ plugin:zotlit:359
eval @ plugin:zotlit:350

@asan-emirsaleh
Copy link
Author

After I deleted colour markup from my notes, "notes" field in template editor worked normally. Lit note was also created normally.
I suggest such coloured highlights processing is to be considered as a #bug @aidenlx

@appwcn
Copy link

appwcn commented May 17, 2024

same issue here.

@appwcn
Copy link

appwcn commented May 22, 2024

#321 是同一个问题。希望作者能够修复…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants