Add custom input policy test #8800
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| # Tech debt : For input policies, we required to have NodeIdentity args beforehand, | ||
| # therefore at this stage we had to return back to the normal args. | ||
| # Maybe there's better way to do it. | ||
| if len(init_args) and isinstance(list(init_args.keys())[0], NodeIdentity): |
There was a problem hiding this comment.
Depending on how urgent this is, could we maybe fix this tech debt? I was thinking over the weekend that maybe this will affect other parts of the codebase, and the solution here is pretty dirty
There was a problem hiding this comment.
Risk level is labeled as high in our spreadsheet. So, I'm guessing its important, but I can't tell how urgent it is. So maybe we can check @madhavajay opinion on it.
But I'm all for looking a cleanest solution. In fact I'd like to refactor a bit the way policies are designed, as we discussed last friday, the workflow is complex and has plenty of indirect effects. But this would require this task to be medium-high size. Do you have any new opinions/ideas on that @teo-milea?
Description
This PR aims to fix CustomInputPolicy creation and usage workflow and add a new test in custom-policy notebook.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist