Generate history conversation filenames in Chinese properly. #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made:
There's a problem with generating history conversation filenames in Chinese and other languages without blanks between words for a long time. If users input their first request in languages like Chinese, they would get a history conversation json file named as something like
__March_28_2024_19-59-01.json
almost every time. This was caused by the old way to generate the first part of filename:self.messages[0]["content"][:25].split(" ")[:-1]
. This would get a blank string if there's no" "
(blank space) in users' first input. I made a small patch to fix this. Now it will name history conversation files like这是一句中文__March_28_2024_19-59-01.json
if got users' first input in Chinese.Reference any relevant issues (e.g. "Fixes #000"):
Pre-Submission Checklist (optional but appreciated):
docs/CONTRIBUTING.md
docs/ROADMAP.md
OS Tests (optional but appreciated):