Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard scrubbing #672

Merged
merged 9 commits into from
May 27, 2024
Merged

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented May 15, 2024

What kind of change does this PR introduce?
This PR adds the ability to scrub recordings and view them later on.

Summary
This PR makes it such that recordings can be scrubbed, with a given provider. Scrubbing a recording means scrubbing all its related action events, window events, and screenshots

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

Copy link
Contributor

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few comments, happy to chat about any of it!

openadapt/app/dashboard/api/recordings.py Show resolved Hide resolved
openadapt/db/crud.py Show resolved Hide resolved
openadapt/db/crud.py Show resolved Hide resolved
openadapt/models.py Outdated Show resolved Hide resolved
openadapt/privacy/base.py Outdated Show resolved Hide resolved
openadapt/privacy/providers/__init__.py Show resolved Hide resolved
openadapt/scrub.py Outdated Show resolved Hide resolved
openadapt/spacy_model_helpers/download_model.py Outdated Show resolved Hide resolved
openadapt/scrub.py Outdated Show resolved Hide resolved
Copy link
Contributor

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit 3083fef into OpenAdaptAI:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants