-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: create trace.py #408
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small things, otherwise looks good!
@dianzrong can you please fix merge conflicts and add a test? At a minimum we want a smoke test that looks like, e.g.:
If you really want to you can simulate some function calls and look in stdout to make sure the calls are logged but it's not necessary. |
What kind of change does this PR introduce?
Refactoring
Summary
Refactor the trace code from record.py to trace.py. Addresses #387
Checklist
How can your code be run and tested?
Can be tested through running record.py