Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloudflare DNS Auth #3764

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix Cloudflare DNS Auth #3764

merged 1 commit into from
May 20, 2024

Conversation

ransbachm
Copy link
Contributor

Fix Cloudflare DNS Auth

Pin version as requested by dependency

Related #3763 #3762 #3756

See #3756 :

2024-05-16 09:46:20 self.cf = CloudFlare.CloudFlare(token=api_token)
2024-05-16 09:46:20 /opt/certbot/lib/python3.11/site-packages/certbot_dns_cloudflare/_internal/dns_cloudflare.py:107: PendingDeprecationWarning:
2024-05-16 09:46:20 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2024-05-16 09:46:20 !! You're seeing this warning because you've upgraded the Python package 'cloudflare' to version !!
2024-05-16 09:46:20 !! 2.20.* via an automated upgrade without version pinning. Version 2.20.0 exists to catch any !!
2024-05-16 09:46:20 !! of these upgrades before Cloudflare releases a new major release under the release number 3.x. !!
2024-05-16 09:46:20 !! !!
2024-05-16 09:46:20 !! Should you determine that you need to revert this upgrade and pin to v2.19.* it is recommended !!
2024-05-16 09:46:20 !! you do the following: pip install --upgrade cloudflare==2.19.* or equivilant. !!
2024-05-16 09:46:20 !! !!
2024-05-16 09:46:20 !! Or you can upgrade to v3.x. NOTE: Release 3.x will not be code-compatible or call-compatible !!
2024-05-16 09:46:20 !! with previous releases. To see more about upgrading to next major version, please see: !!
2024-05-16 09:46:20 !! https://github.com/cloudflare/python-cloudflare/discussions/191 !!
2024-05-16 09:46:20 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

May want to look into how to upgrade to 3.x.x long term

@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3764

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@ransbachm
Copy link
Contributor Author

jc21/nginx-proxy-manager:github-pr-3764

Worked for me

@jc21 jc21 merged commit b383f46 into NginxProxyManager:develop May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants