[move] Add CFGIR Ast Visitor. Clean up rough edges of T::Program. #17787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@tnowacki is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
cgswords
reviewed
May 17, 2024
| } | ||
| } | ||
|
|
||
| fn visit_module( | ||
| fn absint_visit_module( |
There was a problem hiding this comment.
Could we eliminate this by using the new visitor?
There was a problem hiding this comment.
Oh thats fun. Stuffing all of the absint visitors in a visitor?
cgswords
reviewed
May 17, 2024
| self.visit_exp(el); | ||
| self.visit_exp(er); | ||
| } | ||
| Command_::Break(_) | Command_::Continue(_) | Command_::Jump { .. } => (), |
There was a problem hiding this comment.
I wonder if these could report an error somehow.
cgswords
reviewed
May 17, 2024
| if self.visit_constant_custom(module, constant_name, cdef) { | ||
| self.pop_warning_filter_scope(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Do we want to add visit_value and call that here (plus in visit_exp)?
There was a problem hiding this comment.
Sure, seems helpful in the CFGIR
cgswords
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.