improve coin and balance query performance #17774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlmyng
requested review from
amnn,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
reviewed
May 24, 2024
… and modify necessary coin indexes to support coin queries
wlmyng
force-pushed
the
wlmyng/gql/coin-perf-improvements
branch
from
369078d
to
860b552
Compare
…x on owner_id and coin_type
|
Okay, looks like it ultimately comes down to just an indexer db schema change. |
emmazzz
approved these changes
Jun 5, 2024
wlmyng
added a commit
that referenced
this pull request
Jun 5, 2024
## Description We need a dedicated index for `coin_type`. This can be a partial index `WHERE coin_type IS NOT NULL` ## Test plan Manually ran benchmark suite and verified that all benchmarked queries did not timeout and completed within a sensible amount of time. --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need a dedicated index for
coin_type. This can be a partial indexWHERE coin_type IS NOT NULLTest plan
Manually ran benchmark suite and verified that all benchmarked queries did not timeout and completed within a sensible amount of time.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.