Add serial and parallel executor classes #17767
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
|
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
1832164
to
4e831fc
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
4e831fc
to
d0e2917
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
2 times, most recently
from
70d2427
to
342b539
Compare
hayes-mysten
changed the title
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
6b09578
to
9b31ab0
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
3 times, most recently
from
76b2dd0
to
b2ee1df
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
61656f4
to
472522c
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
472522c
to
56f22e9
Compare
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
1f12474
to
5366715
Compare
| - `initialCoinBalance`: The balance of new coins created for the gas pool in MIST (default | ||
| `200_000_000n`), | ||
| - `minimumCoinBalance`: After executing a transaction, the the gasCoin will be reused unless it's | ||
| balance is below this value (default `50_000_000n`), |
There was a problem hiding this comment.
Just curious where these defaults came from
There was a problem hiding this comment.
A lot of small transaction use a little less than 5_000_000 from what I've seen, I figured 10x that would be a reasonable minimum for to account for complex transactions. Then 4x seems safe enough for an initial coin we hope to re-use a lot since most transactions will use less, that would be ~50 cheap transactions for 5 very expensive ones.
200_000_000 * 50 (max size) is 10 SUI which seems like a decent amount to fully fund the initial pool.
It's mostly completely made up without a lot of data to back it up 🤷
hayes-mysten
requested review from
pchrysochoidis and
Nikhil-Mysten
and removed request for
a team
hayes-mysten
force-pushed
the
mh--sdk-v1-serial-executor
branch
from
5366715
to
3582b88
Compare
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.