-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move docs] Add enums to Move reference book #17755
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
2e80233
to
2fc5d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim!
acd3e54
to
034247d
Compare
Thank you for the review and suggestions @ronny-mysten! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
||
You can pattern match on Move values by value, immutable reference, and mutable reference. When | ||
pattern matching by value, the value is moved into the match arm. When pattern matching by | ||
reference, the value is borrowed into the match arm (either immutably or mutably). We'll go through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we tended not to use "We" in docs. cc @ronny-mysten, did I remember that correctly, and if so, what's the alternative in cases like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true for Sui docs. These don't have a style guide and was asked not to provide that level of feedback originally. It's better to just mention that "the instructions...", "the document...", "the following examples..." go through... But because "we" was used throughout, probably best to keep it consistent.
Co-authored-by: ronny-mysten <118224482+ronny-mysten@users.noreply.github.com>
034247d
to
72a51df
Compare
Closing for this PR for the Move book repo instead: MystenLabs/move-book#68 |
Description
Adds documentation for enums to the Move reference book, and also updates the
abilities
section for them.Test plan
👀