Add task uploadCompositeFile #2007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoyaBot
reviewed
Apr 17, 2020
Generated by 🚫 Danger Swift against 15c7705 |
…elbartlett/Moya into feature/upload-file-with-parameters
|
Thanks for the PR @mikaelbartlett, really appreciate it! We're currently trying to figure out if we can get the refactoring PR in the next release - if we do then this PR wouldn't be needed. But in case we won't, we will think about this and the other PR for improving the task type. I'll keep you posted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds missing task for uploading file with URL parameters.
I've seen #1936 and it seems this will solve this issue. This is a small fix to add this task until #1936 is merged and released.