Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumps MMI packages #24581

Merged
merged 7 commits into from
May 20, 2024
Merged

chore: bumps MMI packages #24581

merged 7 commits into from
May 20, 2024

Conversation

zone-live
Copy link
Contributor

Description

A few packages updates for MMI.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label May 17, 2024
@zone-live zone-live requested a review from a team as a code owner May 17, 2024 10:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot metamaskbot requested review from a team as code owners May 17, 2024 10:53
@metamaskbot
Copy link
Collaborator

Builds ready [baa14d6]
Page Load Metrics (1106 ± 628 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631551052914
domContentLoaded97219147
load51384311061309628
domInteractive97219147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.37%. Comparing base (c897b49) to head (1af2956).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24581   +/-   ##
========================================
  Coverage    67.37%   67.37%           
========================================
  Files         1289     1289           
  Lines        50221    50221           
  Branches     13005    13005           
========================================
  Hits         33836    33836           
  Misses       16385    16385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1af2956]
Page Load Metrics (1294 ± 587 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712291174220
domContentLoaded105518115
load57278612941223587
domInteractive105518115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 4cf7e80 into develop May 20, 2024
72 checks passed
@zone-live zone-live deleted the MMI-bumps-packages-versions branch May 20, 2024 09:53
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@metamaskbot metamaskbot added release-11.18.0 Issue or pull request that will be included in release 11.18.0 release-11.17.0 Issue or pull request that will be included in release 11.17.0 and removed release-11.18.0 Issue or pull request that will be included in release 11.18.0 labels May 20, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants