Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock snaps deps for RC #24569

Closed
wants to merge 1 commit into from

Conversation

FrederikBolding
Copy link
Member

Description

Breaking changes were accidentally included in non major versions of the Snaps packages. Out of caution and to fix an RC E2E issue, this PR locks the dependencies to the correct versions. This commit should only be merged into the RC and should not be reflected in develop, where everything is up to date.

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label May 16, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 16, 2024 20:11
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 16, 2024
package.json Show resolved Hide resolved
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrederikBolding Unit tests failing :/

Do you have references for good/bad versions relevant for this PR?

@FrederikBolding
Copy link
Member Author

FrederikBolding commented May 16, 2024

@FrederikBolding Unit tests failing :/

Unrelated it seems, probably just the RC not passing CI yet?

Do you have references for good/bad versions relevant for this PR?

Certain packages (at a minimum snaps-controllers) released here https://github.com/MetaMask/snaps/releases/tag/v45.0.0 should have been major version bumps. To be safe I have just locked the deps to the previous versions, even though not all of them contain breaking changes.

@danjm
Copy link
Contributor

danjm commented May 16, 2024

The unit test failures, and most of the other failures, are resolved by these cherry picks #24564, so not related to this PR

@danjm
Copy link
Contributor

danjm commented May 16, 2024

I am going to pull together the different cherry-picks into one branch to confirm that they get the build fully passing, and I will merge this later tonight after I do that

@FrederikBolding
Copy link
Member Author

Closing as this was cherry-picked into another PR

@FrederikBolding FrederikBolding deleted the fb/lock-snaps-deps-for-rc branch May 21, 2024 09:57
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants