feat: add metametrics to authentication #24555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
… NOTIFY-634-send-metametrics-id-on-login
Comment on lines
+656
to
+663
| getMetaMetricsId() { | ||
| let { metaMetricsId } = this.state; | ||
| if (!metaMetricsId) { | ||
| metaMetricsId = this.generateMetaMetricsId(); | ||
| this.store.updateState({ metaMetricsId }); | ||
| } | ||
| return metaMetricsId; | ||
| } |
There was a problem hiding this comment.
This is the only change to metametrics.
We are not using the server metametrics ID on the clients.
… NOTIFY-634-send-metametrics-id-on-login
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24555 +/- ##
===========================================
+ Coverage 67.37% 67.38% +0.01%
===========================================
Files 1289 1289
Lines 50220 50233 +13
Branches 13005 13006 +1
===========================================
+ Hits 33835 33849 +14
+ Misses 16385 16384 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [995174f]
Page Load Metrics (1569 ± 663 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-11.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows us to create a lineage (in our system), but will not affect our existing metrics.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist