Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactored cli module using corba #915

Open
wants to merge 1 commit into
base: Alpha
Choose a base branch
from
Open

refactor: refactored cli module using corba #915

wants to merge 1 commit into from

Conversation

Kuingsmile
Copy link

In this PR, I have made several modifications to the command-line code. These modifications may be helpful to improve the project's structure, maintainability and more easier to add new features.

@Larvan2 Larvan2 requested a review from H1JK January 5, 2024 06:29
@H1JK
Copy link
Collaborator

H1JK commented Jan 13, 2024 •
edited

When it comes to improving project maintainability, just optimizing command line code may not be enough. Forked from clash, there are many things to do here such as eliminating global variables. This requires a lot of work and definitely make it no longer "clash" so that's how I think why there hasn't anyone done such work before. Also, we would like to do our best to support legacy clients without affecting development (such as Clash for Windows), therefore it is supposed to introducing no big modification to CLI.

New features have been added to HTTP controller in previous development, and we have no idea what to add to CLI command.

Thanks for the PR, but it'll hold off for a while because it is not the time.

@wwqgtxx wwqgtxx force-pushed the Alpha branch 2 times, most recently from 9998f0e to edf318b Compare January 13, 2024 10:15
@Kuingsmile
Copy link
Author

When it comes to improving project maintainability, just optimizing command line code may not be enough. Forked from clash, there are many things to do here such as eliminating global variables. This requires a lot of work and definitely make it no longer "clash" so that's how I think why there hasn't anyone done such work before. Also, we would like to do our best to support legacy clients without affecting development (such as Clash for Windows), therefore it is supposed to introducing no big modification to CLI.

New features have been added to HTTP controller in previous development, and we have no idea what to add to CLI command.

Thanks for the PR, but it'll hold off for a while because it is not the time.

Thanks for your comments.

@Larvan2 Larvan2 force-pushed the Alpha branch 2 times, most recently from 198f41f to 822ba5f Compare February 5, 2024 06:03
@wwqgtxx wwqgtxx force-pushed the Alpha branch 2 times, most recently from c44949b to f3e23b1 Compare April 7, 2024 17:28
@wwqgtxx wwqgtxx force-pushed the Alpha branch 9 times, most recently from ddf6cd3 to ed1e7e3 Compare May 15, 2024 01:14
@Larvan2 Larvan2 force-pushed the Alpha branch 2 times, most recently from f8b27b9 to 094537b Compare May 19, 2024 10:30
@wwqgtxx wwqgtxx force-pushed the Alpha branch 3 times, most recently from de3d214 to 3195c67 Compare May 21, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H1JK H1JK Awaiting requested review from H1JK

Assignees
No one assigned
Labels
priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kuingsmile @H1JK