fix: correct type for vmess.ws-opts.path in ConvertsV2Ray #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be a string for the following reasons: 1. During conversion, it is conditionally assigned with `wsOpts["path"] = path.(string)` 2. After conversion, it is decoded into `WSOptions.Path` in `adapter/outbound/vmess.go` which requires a string.
xishang0128
force-pushed
the
Alpha
branch
4 times, most recently
from
af42ed0
to
3b472f7
Compare
xishang0128
force-pushed
the
Alpha
branch
3 times, most recently
from
ae45564
to
fa46f06
Compare
wwqgtxx
force-pushed
the
Alpha
branch
2 times, most recently
from
c44949b
to
f3e23b1
Compare
wwqgtxx
force-pushed
the
Alpha
branch
9 times, most recently
from
ddf6cd3
to
ed1e7e3
Compare
Larvan2
force-pushed
the
Alpha
branch
2 times, most recently
from
f8b27b9
to
094537b
Compare
wwqgtxx
force-pushed
the
Alpha
branch
3 times, most recently
from
de3d214
to
3195c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a string for the following reasons:
wsOpts["path"] = path.(string)WSOptions.Pathinadapter/outbound/vmess.gowhich requires a string.