-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make private ip the same as geoip:private #1061
base: Alpha
Are you sure you want to change the base?
Conversation
Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs.
https://datatracker.ietf.org/doc/html/rfc1918#section-3 These IPs are not clearly defined |
These are private IPs in https://github.com/MetaCubeX/meta-rules-dat/blob/meta/geo/geoip/private.list |
6321cfb
to
092e535
Compare
其实geoip:private里面的地址不应该叫做Private IP Addresses,而应该是Reserved IP addresses。 |
确实在理 |
这看上去更应该修改geoip-code让它支持多个code,或者增加单独的filter以接受指定IP段的结果 |
99b6ffa
to
44d8a14
Compare
af42ed0
to
3b472f7
Compare
c3fdcff
to
ae45564
Compare
c44949b
to
f3e23b1
Compare
ddf6cd3
to
ed1e7e3
Compare
f8b27b9
to
094537b
Compare
de3d214
to
3195c67
Compare
Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs. This pr uses the CIDR list from geoip:private to fix it.