check for HAS_MULTI_HOTEND in Temperature::getHeaterPower #27037
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Altered this to simply return a dummy power (0) if the index is invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While p3p was updating the sim for multiple extruders and hotend he came across a bug in Marlin.
for full details. https://discord.com/channels/461605380783472640/491105471076368390/1234651377863753829
The issue is that Temperature::getHeaterPower does not know about single hotend options, so the array
temp_hotend[heater_id] goes out of bounds when there is only 1 hotend with multiple extruders.
This fix is just to limit the array to 0 when there is only the 1 hotend
Ie temp_hotend[TERN0(HAS_MULTI_HOTEND, heater_id)]
Requirements
Multiple extruders with a single hotend.
Benefits
Array is not over run.