Set axis colors for Axes class to passed in values; set default axis color to BLACK if no numbers given #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.decimal_number_config["color"] = color.BLACK | ||
|
|
||
| # Now when the configurations are merged, the color will be set to black | ||
| number_config = merge_dicts_recursively( |
Check notice
Code scanning / CodeQL
Unused local variable Note
| # Now when the configurations are merged, the color will be set to black | ||
| number_config = merge_dicts_recursively( | ||
| self.decimal_number_config, | ||
| number_config, |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
The first change is in lines 1873-1882 of coordinate_systems.py. The second change is in Ines 484-490 of number_line.py. This pull request attempts to fix that Axes does not respect the parameters passed in, specifically pertaining to color.
Motivation and Explanation: Why and how do your changes improve the library?
Resolve #3633 . These changes attempt to fix an issue within the initialization of the Axes class in which the axis_config attributes are not accurately set. To account for color not being displayed as per issue 3633, the changes set the color to the parameters passed in, and also set the default color to BLACK if no numbers are given.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist