Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LabeledRectangle Class #3635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Fineas
Copy link

@Fineas Fineas commented Mar 6, 2024

Overview: What does this pull request change?

Introduce a new Class in mobject/geometry/polygram.py

Motivation and Explanation: Why and how do your changes improve the library?

While working with the Graph class I encountered issues with vertexes of type Rectangle, whenever I set labels=True. Thus, I looked at how LabeledDot is defined in arc.py and implemented a Rectangle with support for Label.

Result:

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Create LabeledRectangle Class
@JasonGrace2282 JasonGrace2282 added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Apr 1, 2024
@JasonGrace2282
Copy link
Contributor

To be clear, we didn't forget about this PR. The devs were discussing whether it would be more practical to create a LabeledMixin class, instead of LabeledDot LabeledRectangle and whatever other Labeled* classes people want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

None yet

2 participants