Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console paging #360

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Console paging #360

wants to merge 12 commits into from

Conversation

seliayeu
Copy link
Contributor

Description

Adds pagination for console logs

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit f94a9a8
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/6590ce5101032e0008f7575b
😎 Deploy Preview https://deploy-preview-360--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit f94a9a8
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/6590ce510ff1560009a1333a
😎 Deploy Preview https://deploy-preview-360--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@CheatCod CheatCod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user enters the console page, it should display the latest log, and as the user scrolls up, older logs are fetched

Copy link
Member

@CheatCod CheatCod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem to be working consistently for me, reproducible in the following step

  1. start a Minecraft server
  2. hold down enter key so it generates loads of console logs
  3. refresh the page, I am put on top of the console log but it's incomplete

@CheatCod
Copy link
Member

Add a loading animation to notify the user the page is being fetched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants